Template talk:Dotted cell

From Wikisource
Jump to navigation Jump to search

This is how it breaks. Your change renders all of the text; it originally only renders to the cell. TE(æ)A,ea. (talk) 15:51, 18 September 2022 (UTC)Reply[reply]

@TE(æ)A,ea.: Thanks. And on which page did you observe this? Xover (talk) 16:40, 18 September 2022 (UTC)Reply[reply]
@Xover: I have observed the problems described by TE(æ)A,ea. too, e. g. at Page:The Bohemian Review, vol1, 1917.djvu/48. However, the partial revert by TE(æ)A,ea. did not help much, as its result was no dots at all. So I have returned it to the last working version. --Jan Kameníček (talk) 16:53, 19 September 2022 (UTC)Reply[reply]
@Jan.Kamenicek: Thanks. I think I've tracked down and fixed the problem. Spot-checking shows no problems now, but I could always have missed something so I would appreciate additional checks.
The issue was that this template relied on being used within {{TOC begin}}, so when it wasn't it wasn't getting any of the style definitions it needed to function. In other words, any place {{dotted cell}} was being used without {{TOC begin}} it would be broken. The fix is essentially just to include the stylesheet in this template directly. It's a little bit of extra duplication (inefficient), but it'll have to do.
PS. Did I mention I really really recommend against using any of the dot leader templates? 😎 Xover (talk) 18:59, 19 September 2022 (UTC)Reply[reply]
Thanks for fixing it, it looks good now. And another thanks for helping with various dotted templates despite the fact you do not like them at all! I still prefer using them simply because the tables look too different without them in my eyes, and because many (although not all, I admit) tables would be more difficult to read without the dot leaders. --Jan Kameníček (talk) 19:43, 19 September 2022 (UTC)Reply[reply]